PING Re: RFR: 8078521: AARCH64: Add AArch64 SA support

[Dmitry Samersoff]

Andrew,

Found minor nit in the fix, please update the webrev:

diff -r 640718253035 -r f043d189d1e1
agent/src/share/classes/sun/jvm/hotspot/runtime/aarch64/AARCH64Frame.java
---
a/agent/src/share/classes/sun/jvm/hotspot/runtime/aarch64/AARCH64Frame.java
Tue May 19 15:37:29 2015 +0100
+++
b/agent/src/share/classes/sun/jvm/hotspot/runtime/aarch64/AARCH64Frame.java
Thu Jun 11 16:54:41 2015 +0300
@@ -391,7 +391,7 @@
       map.setIncludeArgumentOops(cb.callerMustGCArguments());

       if (cb.getOopMaps() != null) {
-        OopMapSet.updateRegisterMap(this, cb, map, true);
+        ImmutableOopMapSet.updateRegisterMap(this, cb, map, true);
       }

       // Since the prolog does the save and restore of FP there is no
oopmap


-Dmitry




On 2015-05-19 18:20, Andrew Haley wrote:
> On 05/16/2015 06:03 PM, Dmitry Samersoff wrote:
>> Andrew,
>>
>> On 2015-05-12 20:05, Andrew Haley wrote:
>>> http://cr.openjdk.java.net/~aph/8078521-4/
>>
>> HSDB.java:
>>
>> 988: If you removed else part, you don't need to check CPU here at all,
>>      just leave a comment.
> 
> This will now enable the code for PPC; I guess that's OK.
> 
>> LinuxAARCH64CFrame.java:
>>
>> 65 - it's better to add brackets around 2 * ADDRESS_SIZE
>> 69,73  - please, remove space after bracket.
> 
> Done.
> 
> http://cr.openjdk.java.net/~aph/8078521-5/
> 
> Thanks,
> Andrew.
> 


-- 
Dmitry Samersoff
Oracle Java development team, Saint Petersburg, Russia
* I would love to change the world, but they won't give me the sources.