[8u] RFR(S): Uninitialized memory in set_uintx_flag of attachListener.cpp

David Holmes david.holmes at oracle.com
Tue Dec 6 13:05:24 UTC 2016


On 6/12/2016 9:58 PM, Dmitry Samersoff wrote:
> Everybody,
>
> http://cr.openjdk.java.net/~dsamersoff/JDK-8170536/webrev.01/
>
> Please, review the fix.
>
> The code should return error if op->arg(1) is NULL.

Looks ok. Only minor nit:

  274   const char* arg1;
  275
  276   arg1 = op->arg(1);

can be:

274   const char* arg1 = op->arg(1);

Oh and copyright year needs updating.

Thanks,
David

> -Dmitry
>


More information about the serviceability-dev mailing list