[8u] RFR(S): Uninitialized memory in set_uintx_flag of attachListener.cpp

Dmitry Samersoff dmitry.samersoff at oracle.com
Tue Dec 6 13:22:48 UTC 2016


David,

Thank you!

-Dmitry

On 2016-12-06 16:05, David Holmes wrote:
> On 6/12/2016 9:58 PM, Dmitry Samersoff wrote:
>> Everybody,
>>
>> http://cr.openjdk.java.net/~dsamersoff/JDK-8170536/webrev.01/
>>
>> Please, review the fix.
>>
>> The code should return error if op->arg(1) is NULL.
> 
> Looks ok. Only minor nit:
> 
>  274   const char* arg1;
>  275
>  276   arg1 = op->arg(1);
> 
> can be:
> 
> 274   const char* arg1 = op->arg(1);
> 
> Oh and copyright year needs updating.
> 
> Thanks,
> David
> 
>> -Dmitry
>>


-- 
Dmitry Samersoff
Oracle Java development team, Saint Petersburg, Russia
* I would love to change the world, but they won't give me the sources.


More information about the serviceability-dev mailing list