RFR: (XS): JDK-8068004: [Findbugs]sun.jvm.hotspot.debugger may expose internal representation

Jaroslav Bachorik j.bachorik at gmail.com
Fri Jul 29 11:37:06 UTC 2016


Hi Jini,

'null' seems to be a valid value for 'data' field in both of the places you
are using 'data.clone()' - you should guard for null and call 'clone()'
only if the passed in value is non-null.

Cheers,

-JB-

On Fri, Jul 29, 2016 at 11:29 AM, Jini Susan George <jini.george at oracle.com>
wrote:

> Hi all,
>
> Please review the fix for the following SA defect (to avoid exposing
> internal representations by storing or returning externally mutable
> objects directly).
>
> Bug ID: *https://bugs.openjdk.java.net/browse/JDK-8068004*
> <https://bugs.openjdk.java.net/browse/JDK-8068004>
>
> Webrev:
> *http://cr.openjdk.java.net/~sballal/sponsorship/8068004/webrev.00/*
> <http://cr.openjdk.java.net/~sballal/sponsorship/8068004/webrev.00/>
>
> Thanks,
>
> - Jini Susan George
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20160729/bc1d996c/attachment.html>


More information about the serviceability-dev mailing list