RFR: (XS): JDK-8068004: [Findbugs]sun.jvm.hotspot.debugger may expose internal representation

[Sundararajan Athijegannathan]

If cloning is done to avoid exposing byte[] outside SA, this fix is not
needed in jdk9. In jdk9, none of the SA packages are exposed and code
outside SA cannot access this. Besides, Page data may be very big -
cloning that ever constructor and getter may be too costly.

-Sundar


On 7/29/2016 5:07 PM, Jaroslav Bachorik wrote:
> Hi Jini,
>
> 'null' seems to be a valid value for 'data' field in both of the
> places you are using 'data.clone()' - you should guard for null and
> call 'clone()' only if the passed in value is non-null.
>
> Cheers,
>
> -JB-
>
> On Fri, Jul 29, 2016 at 11:29 AM, Jini Susan George
> <jini.george at oracle.com <mailto:jini.george at oracle.com>> wrote:
>
>     Hi all,
>
>     Please review the fix for the followingSAdefect(to avoid exposing
>     internal representations by storingor returningexternally mutable
>     objectsdirectly).
>
>     Bug ID:_https://bugs.openjdk.java.net/browse/JDK-8068004_
>
>     Webrev:_http://cr.openjdk.java.net/~sballal/sponsorship/8068004/webrev.00/_<http://cr.openjdk.java.net/%7Esballal/sponsorship/8068004/webrev.00/>
>
>     Thanks,
>
>     - Jini Susan George
>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20160729/c9bd6703/attachment-0001.html>