RFR(S): JDK-8152950 BasicLauncherTest.java fails due to type error

[Jaroslav Bachorik]

Hi Dmitry,

#
http://cr.openjdk.java.net/~dsamersoff/JDK-8152950/webrev.03/hotspot_webrev/src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/CommandProcessor.java.sdiff.html
L1752 - wording 'some commands is not available' -> 'some commands will not
be available'

#
http://cr.openjdk.java.net/~dsamersoff/JDK-8152950/webrev.03/jdk_webrev/test/sun/tools/jhsdb/BasicLauncherTest.java.sdiff.html
L100 - I believe it should not say 'Test FAILED'; maybe just 'FAILED'?

Other than that the changes look good.

Cheers,

-JB-

On Thu, May 26, 2016 at 2:12 PM, Dmitry Samersoff <
dmitry.samersoff at oracle.com> wrote:

> Everybody,
>
> Please review the fix.
>
> http://cr.openjdk.java.net/~dsamersoff/JDK-8152950/webrev.03/
>
> This fix cleanup the test and improve error handling in CLHSDB launcher.
>
> The root of the problem is that in modular world nashhorn can't access
> module internal packages ever if they are public. (see details in bug
> report).
>
> Complete fix requires significant efforts and it will be done under
> separate CR (JDK-8157947).
>
> -Dmitry
>
> --
> Dmitry Samersoff
> Oracle Java development team, Saint Petersburg, Russia
> * I would love to change the world, but they won't give me the sources.
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20160526/ad1d197c/attachment.html>