RFR(XS): 8158033: notify_tracing() misplaced for intended purpose

[Markus Gronlund]

Greetings,

 

Please review this small fix:

 

Bug: https://bugs.openjdk.java.net/browse/JDK-8158033

Webrev: http://cr.openjdk.java.net/~mgronlun/8158033/webrev/ 

 

Description:

 

The intent when putting in the notify_tracing() hook into debug.cpp (report_java_out_of_memory()) was to intercept a state believed to be a VM termination state, especially when OOME is thrown. Since it is totally valid that Java code catches OOME, and this location actually goes back to Java, this is the wrong location for this hook.

In addition, the hook should not be typed for OOME only, but generic for any exit condition (normal / OOME / crash). 
This should instead have been put into java.cpp (before_exit()) and in VMError.cpp (report_vm_die()).

 

Thanks

Markus
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20160527/827d750d/attachment.html>