RFR: JDK-8178508 Co-locate remaining MM tests
Igor Ignatyev
igor.ignatyev at oracle.com
Mon Jun 5 22:30:23 UTC 2017
Hello Ujwal,
we usually don't use 'assert' in our tests, we are either using static methods from jdk.test.lib.Assert class or make comparison directly in a test and throw an unchecked exception(I'd recommend AssertionError).
otherwise looks good to me.
-- Igor
> On Jun 1, 2017, at 4:25 AM, Ujwal Vangapally <ujwal.vangapally at oracle.com> wrote:
>
> Gentle reminder.
> Thanks,
>
> Ujwal.
>
> On 5/31/2017 10:32 AM, Ujwal Vangapally wrote:
>> Kindly review the changes made for below bug
>>
>> converted tonga test to JTREG test
>>
>> added an additional assert statement for verifying setusageThreshold() operation is successful
>> https://bugs.openjdk.java.net/browse/JDK-8178508 <https://bugs.openjdk.java.net/browse/JDK-8178508>
>>
>> tonga test case is currently at this path :
>>
>> http://sqe-hgi.us.oracle.com/hg/index.cgi/testbase/javase/functional/9/vm/file/tip/src/nsk/regression/b6653214/ <http://sqe-hgi.us.oracle.com/hg/index.cgi/testbase/javase/functional/9/vm/file/tip/src/nsk/regression/b6653214/>
>>
>>
>> webrev :
>> http://cr.openjdk.java.net/~uvangapally/webrev/2017/8178508/webrev.00/ <http://cr.openjdk.java.net/%7Euvangapally/webrev/2017/8178508/webrev.00/>
>>
>> Thanks,
>>
>> Ujwal.
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20170605/8316ded1/attachment.html>
More information about the serviceability-dev
mailing list