RFR: JDK-8178508 Co-locate remaining MM tests
Ujwal Vangapally
ujwal.vangapally at oracle.com
Wed Jun 14 17:12:39 UTC 2017
Thanks a lot for the review Mandy, Igor, Harsha .
-Ujwal.
On 6/14/2017 10:38 PM, Igor Ignatyev wrote:
> looks good to me as well.
>
> -- Igor
>> On Jun 14, 2017, at 10:06 AM, Ujwal Vangapally
>> <ujwal.vangapally at oracle.com <mailto:ujwal.vangapally at oracle.com>> wrote:
>>
>> Hi Igor can you kindly review this.
>>
>> Thanks,
>>
>> Ujwal
>>
>>
>> On 6/14/2017 9:40 AM, Mandy Chung wrote:
>>>
>>>> On Jun 13, 2017, at 8:13 PM, Ujwal Vangapally
>>>> <ujwal.vangapally at oracle.com <mailto:ujwal.vangapally at oracle.com>>
>>>> wrote:
>>>>
>>>> Thanks for the review Mandy.
>>>>
>>>> updated webrev with simplified version using @requires
>>>> os.simpleArch=="x64".
>>>>
>>>> can't use @requires (os.family != "windows") | (os.simpleArch !=
>>>> "i586")alone as sometimes it might fail on Linux 32bit as well
>>>>
>>>> webrev :
>>>> http://cr.openjdk.java.net/~uvangapally/webrev/2017/8178508/webrev.03
>>>>
>>>>
>>>
>>> This version looks good.
>>>
>>> Mandy
>>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20170614/73893f60/attachment-0001.html>
More information about the serviceability-dev
mailing list