RFR(S) : 8177374 : fix module dependency declaration in jdk_svc tests

Alan Bateman Alan.Bateman at oracle.com
Fri Mar 24 07:10:28 UTC 2017



On 23/03/2017 22:06, Igor Ignatyev wrote:
> Hi Alan,
>
>> I can see what the information tags might be grouped but @library and @modules should also be grouped with the @compile/@run/@build).
> from my point of view, there are 3 different groups of tags:
>   - information tags: @test, @bug, @key, @summary, @author. these tags describe a test, some of them can be used for test selection, but they do not affect test execution.
I agree it's nicer to have most of these grouped, I'm less sure that 
including @summary is always right. The main issue with @summary is that 
it gets very  messy when the descriptions spans multiple lines. Often it 
is better to put the @summary at the end and/or indent the 
second/subsequent lines so that it doesn't gets mixed up with the 
subsequent lines.

>   - declarative tags: @library, @modules, @requires. they change how a test is executed, but they don't specify any test actions
>   - imperative tags: @run and all its shortcuts -- @compile, @build, @ignore. these tags are action tags, their order is important, and they basically define that a test does.
If you group the @modules with @library/@build/@compile/etc. then I'm 
okay. Several of the tests that I looked at in the initial rounds where 
very inconsistent on this and maybe they have been fixed up now.

-Alan


More information about the serviceability-dev mailing list