RFR(S) : 8177374 : fix module dependency declaration in jdk_svc tests

[Igor Ignatyev]

> On Mar 24, 2017, at 12:10 AM, Alan Bateman <Alan.Bateman at oracle.com> wrote:
> On 23/03/2017 22:06, Igor Ignatyev wrote:
>> 
>>> I can see what the information tags might be grouped but @library and @modules should also be grouped with the @compile/@run/@build).
>> from my point of view, there are 3 different groups of tags:
>>  - information tags: @test, @bug, @key, @summary, @author. these tags describe a test, some of them can be used for test selection, but they do not affect test execution.
> I agree it's nicer to have most of these grouped, I'm less sure that including @summary is always right. The main issue with @summary is that it gets very  messy when the descriptions spans multiple lines. Often it is better to put the @summary at the end and/or indent the second/subsequent lines so that it doesn't gets mixed up with the subsequent lines.
if we agreed to have @summary at the end of this group and indent subsequent lines, it will be both readable and grouped w/ other information tags.
in the test you mentioned (test/com/sun/tools/attach/BasicTests.java), we actually had a bug, 'This test will ...' line was passed to a test as an argument, and wasn't a part of summary at all, I saw similar things in many other tests and am planning to fix them in a separate cleanup RFE.

>>  - declarative tags: @library, @modules, @requires. they change how a test is executed, but they don't specify any test actions
>>  - imperative tags: @run and all its shortcuts -- @compile, @build, @ignore. these tags are action tags, their order is important, and they basically define that a test does.
> If you group the @modules with @library/@build/@compile/etc. then I'm okay.
if we group @library w/ @run/@build/@compile we will still have the problem I described w/ adding @ignore. and since @modules and @library are quite different from @run/@build/@compile, I'd prefer to have them in separate groups. could you please elaborate more on why you want to have declarative and imperative tags grouped together?

-- Igor