PRE-RFR: 8177154: Default configuration should disallow loading agents

[Alan Bateman]

On 24/03/2017 08:45, serguei.spitsyn at oracle.com wrote:

> Please, pre-review the JDK 9 fix for:
>   https://bugs.openjdk.java.net/browse/JDK-8177154
>
>
> JDK webrev:
> http://cr.openjdk.java.net/~sspitsyn/webrevs/2017/hotspot/8177154-agents.jdk0/ 
>
>
> Hotspot webrev:
> http://cr.openjdk.java.net/~sspitsyn/webrevs/2017/hotspot/8177154-agents.hs0/ 
>
>
A few initial comment:

I don't think the jdk side should be dependent on the message in the 
reply, it might be simpler to do:
    throw new AgentLoadException("Failed to load agent library: " + message)

As you are changing RunnerUtil then it would be good to trim down the 
line that sets myArgs as it is way too long now for side-by-side reviews.

On the hotspot side then the flag name looks okay to me. In the message 
then "Use flag -XX:..." should be reduced to "Use -XX:..." to term the 
term "flag" out of the message.

-Alan