RFR : JDK-8024352 - MBeanOperationInfo accepts any int value as "impact"

Ujwal Vangapally ujwal.vangapally at oracle.com
Wed Nov 15 13:18:46 UTC 2017


kindly review the updated webrev including changes to 
MBeanInfoHashCodeNPETest.java

webrev : 
http://cr.openjdk.java.net/~uvangapally/webrev/2017/8024352/webrev.05/

Thanks,

Ujwal.


On 11/9/2017 10:33 PM, Ujwal Vangapally wrote:
> Thanks for the review Mandy,
>
> kindly check if this version is better.
>
> webrev : 
> http://cr.openjdk.java.net/~uvangapally/webrev/2017/8024352/webrev.04/
>
> Ujwal
>
>
> On 11/9/2017 9:10 PM, mandy chung wrote:
>>
>>
>> On 11/9/17 2:40 AM, Ujwal Vangapally wrote:
>>> Thanks for the Review Daniel, made changes as suggested.
>>>
>>> webrev : 
>>> http://cr.openjdk.java.net/~uvangapally/webrev/2017/8024352/webrev.03/
>>>
>>
>> Looks good.
>>
>> Minor comment: in the new test, it can fold some of the println 
>> together e.g. line 81 can be merged with line 39 to include the value 
>> being passed.  Similarly for the println in the main method.
>>
>> Mandy
>>
>



More information about the serviceability-dev mailing list