RFR : JDK-8024352 - MBeanOperationInfo accepts any int value as "impact"

[Daniel Fuchs]

Hi Ujwal,

Still looks good to me.

best regards,

-- daniel

On 15/11/2017 13:18, Ujwal Vangapally wrote:
> kindly review the updated webrev including changes to 
> MBeanInfoHashCodeNPETest.java
> 
> webrev : 
> http://cr.openjdk.java.net/~uvangapally/webrev/2017/8024352/webrev.05/
> 
> Thanks,
> 
> Ujwal.
> 
> 
> On 11/9/2017 10:33 PM, Ujwal Vangapally wrote:
>> Thanks for the review Mandy,
>>
>> kindly check if this version is better.
>>
>> webrev : 
>> http://cr.openjdk.java.net/~uvangapally/webrev/2017/8024352/webrev.04/
>>
>> Ujwal
>>
>>
>> On 11/9/2017 9:10 PM, mandy chung wrote:
>>>
>>>
>>> On 11/9/17 2:40 AM, Ujwal Vangapally wrote:
>>>> Thanks for the Review Daniel, made changes as suggested.
>>>>
>>>> webrev : 
>>>> http://cr.openjdk.java.net/~uvangapally/webrev/2017/8024352/webrev.03/
>>>>
>>>
>>> Looks good.
>>>
>>> Minor comment: in the new test, it can fold some of the println 
>>> together e.g. line 81 can be merged with line 39 to include the value 
>>> being passed.  Similarly for the println in the main method.
>>>
>>> Mandy
>>>
>>
>