RFR 8215050: [TESTBUG] serviceability/tmtools/jstack/WaitNotifyThreadTest.java fails when run with flag -Xcomp

Patricio Chilano patricio.chilano.mateo at oracle.com
Sun Dec 9 00:42:23 UTC 2018


Hi David,

On 12/8/18 6:21 PM, David Holmes wrote:
> Hi Patricio,
>
> On 9/12/2018 9:04 am, Patricio Chilano wrote:
>> Hi,
>>
>> Could you review this small fix for test 
>> serviceability/tmtools/jstack/WaitNotifyThreadTest.java ?
>> After change 8214148 the test fails if the flag -Xcomp is used as 
>> explained in the bug details. The proposed change is to identified 
>> this special case and set the monitor address to match the one expected.
>>
>> http://cr.openjdk.java.net/~pchilanomate/8215050.02/webrev/
>> https://bugs.openjdk.java.net/browse/JDK-8215050
>>
>> Run tier-4 where the test was failing and passed (the test was 
>> failing on tier6 also because it uses -Xcomp too). Currently running 
>> tiers1-3.
>
> Change seems fine. The lack of address must be something relatively 
> new as I don't see it with Xcomp in JDK 9.
Thanks for the review!


Thanks,
Patricio
> Thanks,
> David
>
>> Thanks,
>> Patricio



More information about the serviceability-dev mailing list