RFR JDK-8198253: ThreadInfo.from(CompositeData) assigning fields incorrectly in JDK 9
mandy chung
mandy.chung at oracle.com
Sat Feb 24 00:50:39 UTC 2018
Webrev at:
http://cr.openjdk.java.net/~mchung/jdk11/webrevs/8198253/webrev.01
This patch updates the spec to clarify what attributes are required
since which release. There is a spec bug that "classLoaderName"
added in JDK 9 is missing in the CompositeData for StackTraceElement
but the implementation is correct. I will file a CSR for this update.
This patch ensures that CompositeData for ThreadInfo of version N
must have the attributes defined since <= N.
ThreadInfo::from also makes sure 'stackTrace' and 'lockedMonitors'
attributes of version N while it can include additional attributes
which has been the current behavior.
JDK-8139587 intended to support older versions of StackTraceElement
which does not seem a complete solution. I reverted the fix for
JDK-8139587 (mostly) and removed TypeVersionMapper. The fix constructs
the CompositeType for ThreadInfo and MonitorInfo of different
versions and used them for validation. Minor cleanup: the static
final variables are renamed to all capitals. CompatibilityTest.java
test is missing the copyright header.
thanks
Mandy
[1] http://cr.openjdk.java.net/~mchung/jdk11/webrevs/8198253/api/java/lang/management/ThreadInfo.html#from(javax.management.openmbean.CompositeData)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20180223/c2357a32/attachment.html>
More information about the serviceability-dev
mailing list