RFR 8199467 Compilation Errors in libinstrument Reentrancy.c with VS2017
serguei.spitsyn at oracle.com
serguei.spitsyn at oracle.com
Wed Mar 21 19:17:15 UTC 2018
Hi Roger,
It looks good to me.
Thank you for taking care about this!
Thanks,
Serguei
On 3/21/18 12:13, Roger Riggs wrote:
> Please review a small change to avoid sign extension in libinstrument/
> Reentrancy.c
> to correct an compilation warning with vs2017.
>
> diff --git
> a/src/java.instrument/share/native/libinstrument/Reentrancy.c
> b/src/java.instrument/share/native/libinstrument/Reentrancy.c
> --- a/src/java.instrument/share/native/libinstrument/Reentrancy.c
> +++ b/src/java.instrument/share/native/libinstrument/Reentrancy.c
> @@ -90,7 +90,7 @@ assertTLSValue( jvmtiEnv * jvmtienv
> jthread thread,
> const void * expected) {
> jvmtiError error;
> - void * test = (void *) 0x99999999;
> + void * test = (void *) 0x99999999ul;
>
> /* now check if we do a fetch we get what we wrote */
> error = (*jvmtienv)->GetThreadLocalStorage(
>
> Issue:
> https://bugs.openjdk.java.net/browse/JDK-8199467
>
> Thanks, Roger
>
More information about the serviceability-dev
mailing list