RFR 8199467 Compilation Errors in libinstrument Reentrancy.c with VS2017

Martin Buchholz martinrb at google.com
Wed Mar 21 19:31:04 UTC 2018


On Wed, Mar 21, 2018 at 12:13 PM, Roger Riggs <Roger.Riggs at oracle.com>
wrote:

>
> -    void *      test = (void *) 0x99999999;
> +    void *      test = (void *) 0x99999999ul;
>

Martin's 15th law: Never use "l" in a numeric constant unless the constant
is 0xCafeBabel,

so 0x99999999UL
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20180321/f50b6d43/attachment.html>


More information about the serviceability-dev mailing list