RFR 8199467 Compilation Errors in libinstrument Reentrancy.c with VS2017

Roger Riggs Roger.Riggs at Oracle.com
Thu Mar 22 13:46:16 UTC 2018


Hi Martin,

Good recommendation; pushed.

Thanks, Roger



On 3/21/2018 3:31 PM, Martin Buchholz wrote:
>
>
> On Wed, Mar 21, 2018 at 12:13 PM, Roger Riggs <Roger.Riggs at oracle.com 
> <mailto:Roger.Riggs at oracle.com>> wrote:
>
>
>     -    void *      test = (void *) 0x99999999;
>     +    void *      test = (void *) 0x99999999ul;
>
>
> Martin's 15th law: Never use "l" in a numeric constant unless the 
> constant is 0xCafeBabel,
>
> so 0x99999999UL

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20180322/dc3dc502/attachment.html>


More information about the serviceability-dev mailing list