RFR (XS) 8211905: Remove multiple casts for EM06 file

David Holmes david.holmes at oracle.com
Tue Oct 9 06:14:55 UTC 2018


On 9/10/2018 4:08 PM, Chris Plummer wrote:
> Looks good. Any idea what caused it, other than it was introduced by 
> JDK-8209611?

It wasn't in the original webrev for 8209611 (no cast at all) so I'm 
guessing it was a last minute change that somehow went awry. I wonder if 
compilers have a -Wunnecessary_cast warning that may have caught it ;-)

David

> Chris
> 
> On 10/8/18 8:54 PM, JC Beyler wrote:
>> Hi all,
>>
>> Seems like there is an over-zealous casting in the file 
>> nsk/jvmti/scenarios/events/EM06/em06t001/em06t001.cpp:
>>
>> jclassName = (jstring) (jstring) (jstring) (jstring) (jstring) 
>> (jstring) (jstring) (jstring) (jstring) 
>> NSK_CPP_STUB3(CallObjectMethod, jni_env, klass,
>>
>> This webrev fixes that:
>> Webrev: http://cr.openjdk.java.net/~jcbeyler/8211905/webrev.00/ 
>> <http://cr.openjdk.java.net/%7Ejcbeyler/8211905/webrev.00/>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8211905
>>
>> Thanks,
>> Jc
> 
> 


More information about the serviceability-dev mailing list