RFR JDK-8212151: jdi/ExclusiveBind.java times out due to "bind failed: Address already in use" on Solaris-X64

Alex Menkov alexey.menkov at oracle.com
Fri Oct 19 19:36:45 UTC 2018


Hi Jc,

On 10/19/2018 10:34, JC Beyler wrote:
> Hi Alex,
> 
> I remember seeing this same code so went looking for it and saw it in 
> JdbTest.java (you added it here it seems: 
> http://hg.openjdk.java.net/jdk/jdk/rev/083e731da31a).
> 
> I have two few questions:
>    - Does it make sense to put this code in a helper method?

I tried to develop some shared code, but it didn't look good (to me :)
I'll rethink this one more time.

>    - The code you added in JdbTest.java does not do the adjusted time 
> for 30 it seems, is that normal?

Actually adjustment is not needed here as ProcessTools.startProcess 
adjust timeout internally.

--alex

> 
> Thanks,
> Jc
> 
> On Fri, Oct 19, 2018 at 9:59 AM Alex Menkov <alexey.menkov at oracle.com 
> <mailto:alexey.menkov at oracle.com>> wrote:
> 
>     Hi all,
> 
>     jira: https://bugs.openjdk.java.net/browse/JDK-8212151
>     webrev: http://cr.openjdk.java.net/~amenkov/exclusiveBind/webrev/
>     <http://cr.openjdk.java.net/%7Eamenkov/exclusiveBind/webrev/>
> 
>     The fix updates the test to allow debuggee to select available port
>     instead of using error-prone "getFreePort" approach.
> 
>     --alex
> 
> 
> 
> -- 
> 
> Thanks,
> Jc


More information about the serviceability-dev mailing list