RFR (L) 8210429: Clean up JNI_ENV_ARG for vmTestbase/jvmti/Get[G-Z] tests
JC Beyler
jcbeyler at google.com
Fri Sep 7 05:32:32 UTC 2018
Thanks Chris, anybody else motivated to review this?
Thanks in advance!
Jc
On Wed, Sep 5, 2018 at 8:08 PM Chris Plummer <chris.plummer at oracle.com>
wrote:
> Hi JC,
>
> In getstacktr008.cpp, this should be one line:
>
> 240 classDef.class_byte_count =
> 241 env->GetArrayLength(classBytes);
>
> Otherwise looks great!
>
> Chris
>
> On 9/5/18 6:39 PM, JC Beyler wrote:
>
> Hi all,
>
> Continuing the removal of the JNI_ENV* macros, I have done the other half
> of the JVMTI Get[G-Z] methods. The final JVMTI test refactoring will come
> in a final webrev after this one.
>
> The change is straightforward as before, just a bit repetitive:
> Webrev: http://cr.openjdk.java.net/~jcbeyler/8210429/webrev.00/
> Bug: https://bugs.openjdk.java.net/browse/JDK-8210429
>
> I tested this in release mode for the tests that were modified.
>
> Thanks for your reviews,
> Jc
>
>
>
--
Thanks,
Jc
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20180906/f60cc839/attachment.html>
More information about the serviceability-dev
mailing list