RFR (L) 8210429: Clean up JNI_ENV_ARG for vmTestbase/jvmti/Get[G-Z] tests
David Holmes
david.holmes at oracle.com
Fri Sep 7 05:57:25 UTC 2018
Hi Jc,
On 7/09/2018 3:32 PM, JC Beyler wrote:
> Thanks Chris, anybody else motivated to review this?
I skimmed through it and it all seemed okay.
Thanks,
David
> Thanks in advance!
> Jc
>
> On Wed, Sep 5, 2018 at 8:08 PM Chris Plummer <chris.plummer at oracle.com
> <mailto:chris.plummer at oracle.com>> wrote:
>
> Hi JC,
>
> In getstacktr008.cpp, this should be one line:
>
> 240 classDef.class_byte_count =
> 241 env->GetArrayLength(classBytes);
>
> Otherwise looks great!
>
> Chris
>
> On 9/5/18 6:39 PM, JC Beyler wrote:
>> Hi all,
>>
>> Continuing the removal of the JNI_ENV* macros, I have done the
>> other half of the JVMTI Get[G-Z] methods. The final JVMTI test
>> refactoring will come in a final webrev after this one.
>>
>> The change is straightforward as before, just a bit repetitive:
>> Webrev: http://cr.openjdk.java.net/~jcbeyler/8210429/webrev.00/
>> <http://cr.openjdk.java.net/%7Ejcbeyler/8210429/webrev.00/>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8210429
>>
>> I tested this in release mode for the tests that were modified.
>>
>> Thanks for your reviews,
>> Jc
>
>
>
>
> --
>
> Thanks,
> Jc
More information about the serviceability-dev
mailing list