RFR: (trivial) 8210486: Unused code in check_nest_attributes function

David Holmes david.holmes at oracle.com
Fri Sep 7 08:51:54 UTC 2018


Thanks to Mikael V. for finding this. :)

Bug: https://bugs.openjdk.java.net/browse/JDK-8210486
Webrev: http://cr.openjdk.java.net/~dholmes/8210486/webrev/

Trivial code cleanup of unused variable:

--- old/src/hotspot/share/prims/jvmtiRedefineClasses.cpp	2018-09-07 
04:39:40.369608675 -0400
+++ new/src/hotspot/share/prims/jvmtiRedefineClasses.cpp	2018-09-07 
04:39:38.797517530 -0400
@@ -699,7 +699,6 @@
    // Check whether the class NestHost attribute has been changed.
    Thread* thread = Thread::current();
    ResourceMark rm(thread);
-  JvmtiThreadState *state = 
JvmtiThreadState::state_for((JavaThread*)thread);
    u2 the_nest_host_idx = the_class->nest_host_index();
    u2 scr_nest_host_idx = scratch_class->nest_host_index();

Testing:
   - jdk/com/sun/jdi
   - jdk/java/lang/instrument
   - hotspot/runtime/Redefine*
   - hotspot/runtime/appcds/redefineClass
   - tiers 1-3 (mach5)

Thanks,
David




More information about the serviceability-dev mailing list