RFR (L) 8210429: Clean up JNI_ENV_ARG for vmTestbase/jvmti/Get[G-Z] tests

[JC Beyler]

Thanks David and Serguei,

@Serguei: I now added a double check for any change I make to ensure that I
put them on the same line when the line is small (btw, you indeed found the
only case where I missed it)

Have a great weekend,
Jc

On Thu, Sep 6, 2018 at 11:30 PM serguei.spitsyn at oracle.com <
serguei.spitsyn at oracle.com> wrote:

> Hi Jc,
>
> It looks to me.
> One minor comment.
>
>
> http://cr.openjdk.java.net/%7Ejcbeyler/8210429/webrev.00/test/hotspot/jtreg/vmTestbase/nsk/jvmti/GetMethodDeclaringClass/declcls001/declcls001.cpp.udiff.html
>
> -        mid = JNI_ENV_PTR(env)->GetStaticMethodID(JNI_ENV_ARG(env, cl),+        mid = env->GetStaticMethodID(cl,
>              name, sig);
>
> I'd suggest to replace to place the call to just one line.
>
>
> No need for another webrev if you fix it.
>
> Thanks,
> Serguei
>
>
> On 9/5/18 18:39, JC Beyler wrote:
>
> Hi all,
>
> Continuing the removal of the JNI_ENV* macros, I have done the other half
> of the JVMTI Get[G-Z] methods. The final JVMTI test refactoring will come
> in a final webrev after this one.
>
> The change is straightforward as before, just a bit repetitive:
> Webrev: http://cr.openjdk.java.net/~jcbeyler/8210429/webrev.00/
> Bug: https://bugs.openjdk.java.net/browse/JDK-8210429
>
> I tested this in release mode for the tests that were modified.
>
> Thanks for your reviews,
> Jc
>
>
>

-- 

Thanks,
Jc
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20180907/00d3c64a/attachment.html>