RFR 8228589: BasicJStackTest.java and JcmdOutputEncodingTest.java failing after JDK-8227868
Severin Gehwolf
sgehwolf at redhat.com
Thu Jul 25 16:15:09 UTC 2019
Hi Ralf,
On Thu, 2019-07-25 at 15:21 +0000, Schmelter, Ralf wrote:
> Hi Severin,
>
> > I wasn't suggesting to remove the marker. What I meant was to keep the
> > marker at pre-JDK-8227868 state and use a marker with UTF-8 chars for a
> > "testJstackUTF8Output()" test.
>
> There was no marker pre-JDK-8227868. The test only checked for the exit value.
Right. I was thinking this:
http://cr.openjdk.java.net/~sgehwolf/webrevs/rschmelter/JDK-8228589/02/webrev/
> > +1 to reducing the length as long as it continues to reproduce the
> > problem of JDK-8227868 and JDK-8222491.
>
> The original code used a byte array of 256 bytes. For this it is enough to
> make sure the UTF-8 bytes are > 256 and a character cannot start at
> x and x + 256 (it cannot, since the UTF-8 chars repeat every 5 bytes).
> So a repeat value of 60 should be safe.
OK.
Thanks,
Severin
More information about the serviceability-dev
mailing list