RFR: 8220355: Improve assertion texts and exception messages in eventHandlerVMInit

[Roger Riggs]

Hi,

InvocationAdapter.c: 581, remove the space after "(".  As long as that 
line is being changed.

$.02, Roger



On 03/18/2019 06:00 AM, Baesken, Matthias wrote:
>
> Hi Alan, thanks for the review .
>
> >I think this looks okay except I think "emergency" should be dropped 
> from the message (and the existing comment).
>
> Are you referring  to  this “emergency”  :
>
>       *  First make our emergency fallback InternalError throwable.
>
>       */
>
>      result = initializeFallbackError(jnienv);
>
> - jplis_assert(result);
>
> + jplis_assert_msg(result, "emergency fallback init failed");
>
> If you prefer I could  output  just  “fallback init failed"   - is 
> this fine with you?
>
> Best regards, Matthias
>
> *From:*Alan Bateman <Alan.Bateman at oracle.com>
> *Sent:* Montag, 18. März 2019 10:09
> *To:* Baesken, Matthias <matthias.baesken at sap.com>; Jean Christophe 
> Beyler <jcbeyler at google.com>
> *Cc:* serviceability-dev at openjdk.java.net
> *Subject:* Re: RFR: 8220355: Improve assertion texts and exception 
> messages in eventHandlerVMInit
>
>
> On 18/03/2019 08:54, Baesken, Matthias wrote:
>
>     Hi JC, thanks for your comments .
>
>     Second webrev , may I have a second review please ?
>
>     http://cr.openjdk.java.net/~mbaesken/webrevs/8220355.1/
>     <http://cr.openjdk.java.net/%7Embaesken/webrevs/8220355.1/>
>
>
> I think this looks okay except I think "emergency" should be dropped 
> from the message (and the existing comment).
>
> -Alan
>