debugd options should regard to jhsdb style

Jean Christophe Beyler jcbeyler at google.com
Thu May 9 16:17:33 UTC 2019


Hi Osamu,

The patch looks good to me (I'm not an official reviewer though and I
wonder if we should factorize that code a bit, it seems we do the longOpts
with variations of options all over the place and we could just have a
generic one and all call it. But that is a different webrev I think).

Thanks,
Jc

On Thu, May 9, 2019 at 1:34 AM 坂本 統 <sakamoto.osamu at nttcom.co.jp> wrote:

> Hi all,
>
> I want to use `jhsdb debugd` on my laptop.
> However debugd mode has different options from other modes.
> I think debugd should have same options like other modes.
>
> For example, `jhsdb debugd <pid>` should be `jhsdb debugd --pid <pid>`.
> Also I added `--serverid` option for serverid.
>
> I attached a patch for this enhancement.
> This patch passes serviceability/sa jtreg tests.
>
> Testcase for debugd is available as
> serviceability/sa/sadebugd/SADebugDTest.java .
> However it has been disabled by JDK-8163805.
> It will be fixed by Yasumasa Suenaga (ysuenaga) after my proposal has been
> merged.
>
> Could you help? I want to contribute it. I need a sponsor.
> (My company has signed to OCA (NTT Comware Corporation))
>
> Thanks,
>
> Osamu
>
>

-- 

Thanks,
Jc
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20190509/8cf071ba/attachment.html>


More information about the serviceability-dev mailing list