RFR (S) 8224796: C code is not compiled correctly due to undefined "i386"

[David Holmes]

Hi Aleksey,

On 27/05/2019 8:36 pm, Aleksey Shipilev wrote:
> Bug:
>    https://bugs.openjdk.java.net/browse/JDK-8224796
> 
> x86_32 tier1 tests time out (actually, fail) because of this.
> 
> In short, recent change to compile C code with --std=c99 got "i386" undefined. Build system still
> sets "i586", and we should really use that. I don't want to regress stuff much by globally replacing
> i386->i586, so the new code handles *both* defines. This is what "handle both x86_64 and amd64"
> block in LinuxDebuggerLocal.c already does.

I think the existing logic in that file is already quite confused. It 
should be using defines set by the build system only, to identify CPU 
etc, not compiler specific defines. So I really don't think we need to 
keep the i386 stuff in that file as it just adds to the confusion. But I 
won't fight you on it.

> I have not seen the failures on Mac due to ps_core.c, but it is better to be safe there as well.

There is no 32-bit macOS build AFAIK.

Thanks,
David

> Fix:
>    http://cr.openjdk.java.net/~shade/8224796/webrev.01/
> 
> Testing: {x86_64, x86_32} tier1; jdk-submit (running)
>