RFR(XXS): 8241951: ClhsdbCDSCore.java failed to find core file

[Daniel D. Daugherty]

On 8/7/20 6:25 PM, Chris Plummer wrote:
> On 8/7/20 3:22 PM, Chris Plummer wrote:
>> On 8/7/20 3:11 PM, Daniel D. Daugherty wrote:
>>> On 8/7/20 6:03 PM, Chris Plummer wrote:
>>>> Hello,
>>>>
>>>> Please review the following:
>>>>
>>>> https://bugs.openjdk.java.net/browse/JDK-8241951
>>>> http://cr.openjdk.java.net/~cjplummer/8241951/webrev.00/index.html
>>>
>>> test/lib/jdk/test/lib/util/CoreUtils.java
>>>     L139:                 if (Platform.getOsVersionMajor() == 10 && 
>>> Platform.getOsVersionMinor() >= 15) {
>>>         Should the major version check be ">= 10"?
>> If I'm going to check for >= 10, then it needs to be something like :
>>
>>    if (major > 10 || (major == 10 && minor >= 15)
>>
>             if (Platform.isSignedOSX()) {
>                 if (Platform.getOsVersionMajor() > 10 ||
>                     (Platform.getOsVersionMajor() == 10 && 
> Platform.getOsVersionMinor() >= 15))
>                 {
>                     // We can't generate cores files with signed 
> binaries on OSX 10.15 and later.
>                     throw new SkippedException("Cannot produce core 
> file with signed binary on OSX 10.15 and later");
>                 }
>             }
>
> I'll send an updated webrev if you're ok with this

I'm okay with (I don't need another webrev), but other folks might
want one...

Dan

>
> thanks
>
> Chris
>>>
>>>         Platform.isSignedOSX() would return true for signed 11.X. 
>>> Dunno.
>>>
>> Yes, it would return true for 11.x if signed, which is what we would 
>> want.
>>
>> Chris
>>>
>>> Thumbs up.
>>>
>>> Dan
>>>
>>>
>>>>
>>>> We need to disable SA core file testing on OSX 10.15.* and later 
>>>> when the binary is signed because OSX will no longer produce core 
>>>> files with this configuration.
>>>>
>>>> thanks,
>>>>
>>>> Chris
>>>
>>
>>
>