RFR(XS): JDK-8217441: Failure of ::realloc() should be handled correctly in sawindbg.cpp

serguei.spitsyn at oracle.com serguei.spitsyn at oracle.com
Wed Mar 11 23:04:50 UTC 2020


Hi Alex,

It looks good to me.
It seems, returning S_FALSE from SAOutputCallbacks::Output should be 
okay as the same is done when nullptr is returned from malloc.

Thanks,
Serguei


On 3/11/20 15:29, Alex Menkov wrote:
> Hi all,
>
> please review small (and I'd say trivial) fix for
> https://bugs.openjdk.java.net/browse/JDK-8217441
> webrev:
> http://cr.openjdk.java.net/~amenkov/jdk15/WinDbg_realloc/webrev/
>
> from realloc() spec:
> On failure, returns a null pointer. The original pointer ptr remains 
> valid and may need to be deallocated with free() or realloc().
>
> --alex



More information about the serviceability-dev mailing list