RFR(XS): JDK-8217441: Failure of ::realloc() should be handled correctly in sawindbg.cpp

[Alex Menkov]

On 03/11/2020 16:04, serguei.spitsyn at oracle.com wrote:
> Hi Alex,
> 
> It looks good to me.
> It seems, returning S_FALSE from SAOutputCallbacks::Output should be 
> okay as the same is done when nullptr is returned from malloc.

Accordingly MSDN returned value is ignored by debugger engine.
But I keept it as it was.

--alex

> 
> Thanks,
> Serguei
> 
> 
> On 3/11/20 15:29, Alex Menkov wrote:
>> Hi all,
>>
>> please review small (and I'd say trivial) fix for
>> https://bugs.openjdk.java.net/browse/JDK-8217441
>> webrev:
>> http://cr.openjdk.java.net/~amenkov/jdk15/WinDbg_realloc/webrev/
>>
>> from realloc() spec:
>> On failure, returns a null pointer. The original pointer ptr remains 
>> valid and may need to be deallocated with free() or realloc().
>>
>> --alex
>