RFR: 8256450: Add gz option to jmap to write a gzipped heap dump [v2]

[Chris Plummer]

On Wed, 18 Nov 2020 19:53:42 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:

>> Hi @plummercj,
>>      For old jmap, if "gz" option is used in commandline, it prompt usage info indicating that option is illegal.
>>      if "gz" option is not used, the op->arg(2) will be an empty string "", which is set from the attacher side in the method execute() of VirtualMachineImpl.java.
>
> Ok, I see now that 3 args are always written, even if empty, so you at least get a "" if there is no value for the argument position.

I think you need to add a test case. You can use the work done for JDK-8237354 dcmd as a template. See http://cr.openjdk.java.net/~rschmelter/webrevs/8237354/webrev.3/. I don't know that's it's necessary to add a test case for each GC, but if you do, I suggest putting them all in one file. The use of separate files per test case was not necessary.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1251