RFR: 8256450: Add gz option to jmap to write a gzipped heap dump [v2]

Lin Zang lzang at openjdk.java.net
Thu Nov 19 06:08:04 UTC 2020


On Wed, 18 Nov 2020 19:55:48 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:

> I think you need to add a test case. You can use the work done for JDK-8237354 dcmd as a template. See http://cr.openjdk.java.net/~rschmelter/webrevs/8237354/webrev.3/. I don't know that's it's necessary to add a test case for each GC, but if you do, I suggest putting them all in one file. The use of separate files per test case was not necessary.

I extended the BasicJMapTest.java to test the compressed heap dump. would you like to help review?
Thanks!

-------------

PR: https://git.openjdk.java.net/jdk/pull/1251


More information about the serviceability-dev mailing list