RFR: 8254861: reformat code in vmTestbase/nsk/jdb [v2]

Igor Ignatyev iignatyev at openjdk.java.net
Mon Oct 19 21:00:21 UTC 2020


On Mon, 19 Oct 2020 18:51:15 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:

>> Igor Ignatyev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   update copyright years
>
> test/hotspot/jtreg/vmTestbase/nsk/jdb/fields/fields001/fields001.java line 108:
> 
>> 106:             "ii_aa", "oi_aa",
>> 107:             "ii_aaa", "oi_aaa"
>> 108:     };
> 
> Why are these indented 8 instead of 4?

b/c you get indentation unit for each block,  1st block is `fields001` class definition, next block is the array
initializations (start at L#86 and L#99 for `checkedFields1` and `checkedFields2` respecitively)

> test/hotspot/jtreg/vmTestbase/nsk/jdb/hidden_class/hc001/hc001.java line 323:
> 
>> 321:                 "xx.yyy/0x111/0x222",
>> 322:                 "xx./0x111.0x222",
>> 323:                 "xx.yyy.zzz/"
> 
> Why are these indented 8 instead of 4?

due to the same reasons in the case w/ `fields001`, these lines have 3 unit indentation, 1st for `hc001` class, 2nd for
`testInvalidCommands` method, 3rd for `invClassNames` array initialization, so they have 3x4 = 12 spaces.

-------------

PR: https://git.openjdk.java.net/jdk/pull/689


More information about the serviceability-dev mailing list