RFR: 8254861: reformat code in vmTestbase/nsk/jdb [v2]

Chris Plummer cjplummer at openjdk.java.net
Tue Oct 20 00:00:08 UTC 2020


On Mon, 19 Oct 2020 20:55:01 GMT, Igor Ignatyev <iignatyev at openjdk.org> wrote:

>> test/hotspot/jtreg/vmTestbase/nsk/jdb/fields/fields001/fields001.java line 108:
>> 
>>> 106:             "ii_aa", "oi_aa",
>>> 107:             "ii_aaa", "oi_aaa"
>>> 108:     };
>> 
>> Why are these indented 8 instead of 4?
>
> b/c you get indentation unit for each block,  1st block is `fields001` class definition, next block is the array
> initializations (start at L#86 and L#99 for `checkedFields1` and `checkedFields2` respecitively)

I don't follow. You seem to have added an extra 4 (after having already indented 4 extra spaces) simply because it is
an array initialization. Why is the indentation any different than it would be for something like a "for" loop block.
The body of the block is indented 4 spaces more than the "for" statement.  For the static initialization the body of
that "static" block should be indented 4 more than the "static" statement. I don't see anything in the style guide that
would indicate otherwise.

-------------

PR: https://git.openjdk.java.net/jdk/pull/689


More information about the serviceability-dev mailing list