RFR: 8252933: com.sun.tools.jdi.ObjectReferenceImpl#validateAssignment always requests referenceType

Fri Sep 11 04:02:58 UTC 2020

On Fri, 11 Sep 2020 01:08:53 GMT, Daniil Titov <dtitov at openjdk.org> wrote:

> The change fixes the regression introduced by https://bugs.openjdk.java.net/browse/JDK-8241080.
> 
> Method validateAssignment() in com.sun.tools.jdi.ObjectReferenceImpl now always retrieves the reference type and that
> requires one more JDWP packet if the value is not cached yet. Before https://bugs.openjdk.java.net/browse/JDK-8241080
> this happened for arrays only.   Testing: tier1-tier3 tests passes.

The changes look good to me. Can I ask how you noticed the extra unnecessary JDWP packet?

-------------

Marked as reviewed by cjplummer (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/124