RFR: 8252933: com.sun.tools.jdi.ObjectReferenceImpl#validateAssignment always requests referenceType
Daniil Titov
dtitov at openjdk.java.net
Fri Sep 11 16:30:25 UTC 2020
On Fri, 11 Sep 2020 04:00:35 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:
>> The change fixes the regression introduced by https://bugs.openjdk.java.net/browse/JDK-8241080.
>>
>> Method validateAssignment() in com.sun.tools.jdi.ObjectReferenceImpl now always retrieves the reference type and that
>> requires one more JDWP packet if the value is not cached yet. Before https://bugs.openjdk.java.net/browse/JDK-8241080
>> this happened for arrays only. Testing: tier1-tier3 tests passes.
>
> The changes look good to me. Can I ask how you noticed the extra unnecessary JDWP packet?
Thanks @plummercj for the review. The issue with an extra JDWP packet was reported in serviceability-dev mail list :
https://mail.openjdk.java.net/pipermail/serviceability-dev/2020-September/032960.html .
-------------
PR: https://git.openjdk.java.net/jdk/pull/124
More information about the serviceability-dev
mailing list