RFR: 8252001: remove usage of PropertyResolvingWrapper in vmTestbase/nsk/jdi

Igor Ignatyev iignatyev at openjdk.java.net
Wed Sep 30 16:21:15 UTC 2020


On Wed, 30 Sep 2020 04:25:11 GMT, Serguei Spitsyn <sspitsyn at openjdk.org> wrote:

>> Hi all,
>> 
>> could you please review the patch which removes `PropertyResolvingWrapper` from `vmTestbase/nsk/jdi`? other than the
>> removal of `PropertyResolvingWrapper` from jtreg actions, the patch also
>>  - `s/"-debugee.vmkeys=/-debugee.vmkeys="/`
>>  - removed `ExecDriver` there it's not needed anymore
>>  - as jtreg doesn't support static nested classes as main test classes, all `EventTestTemplates`s inner classes were moved
>>    up and the tests were updated accordingly
>>  - appended ${java.class.path} to `-cp` in the tests which specify classpath, otherwise, these tests fail due to CNFE of
>>    jtreg tests
>>  - escaped `"` on windows in `nsk.share.jdi.Binder`
>>  - replaced default quote (`"`) w/ `\0` in `n.s.j.Binder` so there will be no clashes w/ `"` from actions
>> 
>> testing: ✅ `vmTestbase/nsk/jdi` tests on `{linux,windows,macos}-x64`
>
> @iignatev
> Thank you for explanation and filing a new bug.
> I'm okay with this update.

for the record, the RFE to clean up the comments -- [8253864](https://bugs.openjdk.java.net/browse/JDK-8253864)

-------------

PR: https://git.openjdk.java.net/jdk/pull/379


More information about the serviceability-dev mailing list