Integrated: 8252001: remove usage of PropertyResolvingWrapper in vmTestbase/nsk/jdi

Igor Ignatyev iignatyev at openjdk.java.net
Wed Sep 30 16:21:17 UTC 2020


On Mon, 28 Sep 2020 14:09:59 GMT, Igor Ignatyev <iignatyev at openjdk.org> wrote:

> Hi all,
> 
> could you please review the patch which removes `PropertyResolvingWrapper` from `vmTestbase/nsk/jdi`? other than the
> removal of `PropertyResolvingWrapper` from jtreg actions, the patch also
>  - `s/"-debugee.vmkeys=/-debugee.vmkeys="/`
>  - removed `ExecDriver` there it's not needed anymore
>  - as jtreg doesn't support static nested classes as main test classes, all `EventTestTemplates`s inner classes were moved
>    up and the tests were updated accordingly
>  - appended ${java.class.path} to `-cp` in the tests which specify classpath, otherwise, these tests fail due to CNFE of
>    jtreg tests
>  - escaped `"` on windows in `nsk.share.jdi.Binder`
>  - replaced default quote (`"`) w/ `\0` in `n.s.j.Binder` so there will be no clashes w/ `"` from actions
> 
> testing: ✅ `vmTestbase/nsk/jdi` tests on `{linux,windows,macos}-x64`

This pull request has now been integrated.

Changeset: 8f7c9a7b
Author:    Igor Ignatyev <iignatyev at openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/8f7c9a7b
Stats:     3401 lines in 1157 files changed: 588 ins; 397 del; 2416 mod

8252001: remove usage of PropertyResolvingWrapper in vmTestbase/nsk/jdi

Reviewed-by: cjplummer, sspitsyn

-------------

PR: https://git.openjdk.java.net/jdk/pull/379


More information about the serviceability-dev mailing list