RFR: 8253878: clean up nsk/share/jvmti/ArgumentHandler
Chris Plummer
cjplummer at openjdk.java.net
Wed Sep 30 23:03:38 UTC 2020
On Wed, 30 Sep 2020 22:11:43 GMT, Igor Ignatyev <iignatyev at openjdk.org> wrote:
> Hi all,
>
> could you please review this small patch which reformats `ArgumentHandler`, removes unused
> `findOptionStringValue(String name, String defaultValue)` method, fixes typos?
test/hotspot/jtreg/vmTestbase/nsk/share/jvmti/ArgumentHandler.java line 104:
> 102: * or null if this option has no value
> 103: * @return <i>true</i> if option is admissible and has proper value;
> 104: * <i>false</i> if option is not admissible
Why is this line not indented?
test/hotspot/jtreg/vmTestbase/nsk/share/jvmti/ArgumentHandler.java line 126:
> 124: * If optionString is <i>null</i> this method just does nothing.
> 125: *
> 126: * @throws BadOption if known option has illegal value
Shouldn't BadOption use <i\> or <code\>?
-------------
PR: https://git.openjdk.java.net/jdk/pull/443
More information about the serviceability-dev
mailing list