RFR: 8253878: clean up nsk/share/jvmti/ArgumentHandler

Igor Ignatyev iignatyev at openjdk.java.net
Wed Sep 30 23:19:52 UTC 2020


On Wed, 30 Sep 2020 23:00:30 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:

>> Hi all,
>> 
>> could you please review this small patch which reformats `ArgumentHandler`, removes unused
>> `findOptionStringValue(String name, String defaultValue)` method, fixes typos?
>
> test/hotspot/jtreg/vmTestbase/nsk/share/jvmti/ArgumentHandler.java line 126:
> 
>> 124:      * If optionString is <i>null</i> this method just does nothing.
>> 125:      *
>> 126:      * @throws BadOption if known option has illegal value
> 
> Shouldn't BadOption use <i\> or <code\>?

no, `@throws` should be followed by exception class-name, see [1]

[1]: https://docs.oracle.com/en/java/javase/15/docs/specs/javadoc/doc-comment-spec.html#throws

-------------

PR: https://git.openjdk.java.net/jdk/pull/443


More information about the serviceability-dev mailing list