RFR: 8253878: clean up nsk/share/jvmti/ArgumentHandler

Igor Ignatyev iignatyev at openjdk.java.net
Wed Sep 30 23:23:55 UTC 2020


On Wed, 30 Sep 2020 22:58:38 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:

>> Hi all,
>> 
>> could you please review this small patch which reformats `ArgumentHandler`, removes unused
>> `findOptionStringValue(String name, String defaultValue)` method, fixes typos?
>
> test/hotspot/jtreg/vmTestbase/nsk/share/jvmti/ArgumentHandler.java line 104:
> 
>> 102:      *               or null if this option has no value
>> 103:      * @return <i>true</i> if option is admissible and has proper value;
>> 104:      * <i>false</i> if option is not admissible
> 
> Why is this line not indented?

I guess b/c this is how IDEA thinks `@return` javadoc should be aligned. I have checked `java.base` javadoc, and some
classes have indentation here, some don't. either way is fine w/ me.

-------------

PR: https://git.openjdk.java.net/jdk/pull/443


More information about the serviceability-dev mailing list