RFR: 8253878: clean up nsk/share/jvmti/ArgumentHandler
Chris Plummer
cjplummer at openjdk.java.net
Wed Sep 30 23:30:32 UTC 2020
On Wed, 30 Sep 2020 23:17:26 GMT, Igor Ignatyev <iignatyev at openjdk.org> wrote:
>> test/hotspot/jtreg/vmTestbase/nsk/share/jvmti/ArgumentHandler.java line 126:
>>
>>> 124: * If optionString is <i>null</i> this method just does nothing.
>>> 125: *
>>> 126: * @throws BadOption if known option has illegal value
>>
>> Shouldn't BadOption use <i\> or <code\>?
>
> no, `@throws` should be followed by exception class-name, see [1]
>
> [1]: https://docs.oracle.com/en/java/javase/15/docs/specs/javadoc/doc-comment-spec.html#throws
ok
>> test/hotspot/jtreg/vmTestbase/nsk/share/jvmti/ArgumentHandler.java line 104:
>>
>>> 102: * or null if this option has no value
>>> 103: * @return <i>true</i> if option is admissible and has proper value;
>>> 104: * <i>false</i> if option is not admissible
>>
>> Why is this line not indented?
>
> I guess b/c this is how IDEA thinks `@return` javadoc should be aligned. I have checked `java.base` javadoc, and some
> classes have indentation here, some don't. either way is fine w/ me.
Ok. I just noticed the indentation was removed and wondered why.
-------------
PR: https://git.openjdk.java.net/jdk/pull/443
More information about the serviceability-dev
mailing list