RFR: 8257234 : Add gz option to SA jmap to write a gzipped heap dump [v13]

Lin Zang lzang at openjdk.java.net
Fri Jan 29 05:17:45 UTC 2021


On Thu, 28 Jan 2021 22:33:53 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:

>> Lin Zang has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fix the logic of using gz= as file name
>
> You added clhsdb testing to ClhsdbDumpheap.java, but I had also suggested adding testing to BasicJMapTest.java to test pmap. Can you please add some testing there also?

Hi @plummercj, 
I have found that there is a bug in jcmd jmap, it could accept the argument "gz=" with no value specified. 
so jmap -dump:file=a.hprof,gz= <pid> could generate dump file successfully. 

do you think it is ok to fix it in this PR together? or to create a new issue and submit a new PR for this ?

BRs,
Lin

-------------

PR: https://git.openjdk.java.net/jdk/pull/1712


More information about the serviceability-dev mailing list