RFR: 8257234 : Add gz option to SA jmap to write a gzipped heap dump [v13]

Lin Zang lzang at openjdk.java.net
Fri Jan 29 05:39:59 UTC 2021


On Fri, 29 Jan 2021 05:33:19 GMT, Serguei Spitsyn <sspitsyn at openjdk.org> wrote:

> You are right.
> So, in my suggestion just replace this block:
> 
> ```
>                         if (gzlevel <= 0 || gzlevel > 9) {
>                             err.println("Invalid "gz=" option: " + option);
>                             usage();
>                             return;
>                         }
> ```
> 
> with:
> 
> ```
>                         if (gzlevel == 0) {
>                             usage();
>                             return;
>                         }
> ```

Thanks, just found there can be two prints of same error for option like gz=abc,
I will change back:)

-------------

PR: https://git.openjdk.java.net/jdk/pull/1712


More information about the serviceability-dev mailing list