RFR: 8269770: nsk tests should start IOPipe channel before launch debuggee - Debugee.prepareDebugee

[Serguei Spitsyn]

On Thu, 1 Jul 2021 23:21:03 GMT, Alex Menkov <amenkov at openjdk.org> wrote:

> The change fixes several hundreds tests which launch debugee by using uses Debugee.prepareDebugee() method or use 
> debugee = Binder.bindToDebugee(...);
> IOPipe pipe = debugee.createIOPipe();
> logic.
> Debugee.prepareDebugee() and Binder.bindToDebugee() launch debuggee by using CommandLineLaunch JDI connector with suspend=="true" argument, so they return debuggee suspended before the main class is loaded.
> The fix starts IOPipe listening before debuggee VM is resumed.
> 
> Simplified isPackagePrivate/accipp001.java test to use Debugee.prepareDebugee() - it does exactly the same as Debugee.prepareDebugee() does (the only difference is using deprecated IOPipe ctor instead of Debugee.createIOPipe())
> 
> Tested all affected tests:
> test/hotspot/jtreg/vmTestbase/nsk/jdi
> test/hotspot/jtreg/vmTestbase/nsk/jdwp
> test/hotspot/jtreg/serviceability/dcmd

Marked as reviewed by sspitsyn (Reviewer).

test/hotspot/jtreg/vmTestbase/nsk/share/jpda/DebugeeProcess.java line 111:

> 109:     // --------------------------------------------------- //
> 110: 
> 111:     /** Created and return new IOPipe channel to the debuggee VM.

Not your typo but would be nice to fix this in the comment:  "Created" => "Create"

-------------

PR: https://git.openjdk.java.net/jdk/pull/4659