RFR: 8269770: nsk tests should start IOPipe channel before launch debuggee - Debugee.prepareDebugee [v2]

Alex Menkov amenkov at openjdk.java.net
Fri Jul 2 19:30:11 UTC 2021


> The change fixes several hundreds tests which launch debugee by using uses Debugee.prepareDebugee() method or use 
> debugee = Binder.bindToDebugee(...);
> IOPipe pipe = debugee.createIOPipe();
> logic.
> Debugee.prepareDebugee() and Binder.bindToDebugee() launch debuggee by using CommandLineLaunch JDI connector with suspend=="true" argument, so they return debuggee suspended before the main class is loaded.
> The fix starts IOPipe listening before debuggee VM is resumed.
> 
> Simplified isPackagePrivate/accipp001.java test to use Debugee.prepareDebugee() - it does exactly the same as Debugee.prepareDebugee() does (the only difference is using deprecated IOPipe ctor instead of Debugee.createIOPipe())
> 
> Tested all affected tests:
> test/hotspot/jtreg/vmTestbase/nsk/jdi
> test/hotspot/jtreg/vmTestbase/nsk/jdwp
> test/hotspot/jtreg/serviceability/dcmd

Alex Menkov has updated the pull request incrementally with one additional commit since the last revision:

  Fixed comment

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/4659/files
  - new: https://git.openjdk.java.net/jdk/pull/4659/files/8c46ee02..854df1c9

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=4659&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=4659&range=00-01

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jdk/pull/4659.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/4659/head:pull/4659

PR: https://git.openjdk.java.net/jdk/pull/4659


More information about the serviceability-dev mailing list