RFR: 8269886: Inaccurate error message for compressed hprof test [v2]
Chris Plummer
cjplummer at openjdk.java.net
Tue Jul 6 18:14:49 UTC 2021
On Tue, 6 Jul 2021 06:32:12 GMT, Lin Zang <lzang at openjdk.org> wrote:
>> The current implementation of hprof Reader for testing always prompts "Can not decompress the compressed hprof file" when there is error for testing gzipped heap dump. This is inaccurate if the gzipped file was decompressed successfully but the hprof file format is incorrect. So the inaccurate error message could be misleading for issue analysis.
>>
>> This trivial PR refine the error message by simply print "Can not get stack trace from the compressed hprof file", the underlying exception from GZIPInputStream() or HprofReader() would give accurate error info.
>
> Lin Zang has updated the pull request incrementally with one additional commit since the last revision:
>
> divid the try block
After decompressing, no error or exception is thrown if MAGIC_NUMBER is not found. It just silently fails to print the stack trace.
Please use "cannot" instead of "can not". Both are grammatically correct, but "cannot" is what is normally used.
-------------
PR: https://git.openjdk.java.net/jdk/pull/4685
More information about the serviceability-dev
mailing list