RFR: 8269886: Inaccurate error message for compressed hprof test [v2]
Lin Zang
lzang at openjdk.java.net
Wed Jul 7 00:44:12 UTC 2021
On Tue, 6 Jul 2021 18:12:09 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:
>> Lin Zang has updated the pull request incrementally with one additional commit since the last revision:
>>
>> divid the try block
>
> After decompressing, no error or exception is thrown if MAGIC_NUMBER is not found. It just silently fails to print the stack trace.
>
> Please use "cannot" instead of "can not". Both are grammatically correct, but "cannot" is what is normally used.
Hi @plummercj ,
Thanks for reviewing, I have updated the PR based on your comments, and remove unreachable code introduced by the updated code.
BRs,
Lin
-------------
PR: https://git.openjdk.java.net/jdk/pull/4685
More information about the serviceability-dev
mailing list